GitHub user PurelyApplied reopened a pull request:
https://github.com/apache/geode/pull/730
GEODE-3472: Remove a great deal of commented-out code.
* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals,
etc.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [n/a] Have you written or updated unit tests to verify your changes?
[n/a: Non-functional changes.]
- [n/a] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PurelyApplied/geode geode-3472
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/730.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #730
----
commit 80f44577b8f1431c14934a935f6d426f28ed0dea
Author: Patrick Rhomberg <prhomb...@pivotal.io>
Date: 2017-08-18T20:59:44Z
GEODE-3472: Remove a great deal of commented-out code.
* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals,
etc.
commit 7a0db737bc7327adea58a5c972ad04856850c8b7
Author: Patrick Rhomberg <prhomb...@pivotal.io>
Date: 2017-08-28T20:41:19Z
GEODE-3472: Suggested changes in pull request.
* Corrected incorrect correction of a typo in Gfsh.java
* Removed dead, trivial method
* Moved constant field from MBeanJMXAdapter to its use in VMStatsMonitor
commit 1324ed15533dbf5fe95a81e214d81d2355f239fd
Author: Patrick Rhomberg <prhomb...@pivotal.io>
Date: 2017-08-28T22:10:51Z
empty commit to trigger Travis.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
