Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136638047
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java
---
@@ -41,44 +44,34 @@ public Result exportData(
@CliOption(key = CliStrings.EXPORT_DATA__REGION, mandatory = true,
optionContext = ConverterHint.REGION_PATH,
help = CliStrings.EXPORT_DATA__REGION__HELP) String regionName,
- @CliOption(key = CliStrings.EXPORT_DATA__FILE, mandatory = true,
+ @CliOption(key = CliStrings.EXPORT_DATA__FILE,
help = CliStrings.EXPORT_DATA__FILE__HELP) String filePath,
+ @CliOption(key = CliStrings.EXPORT_DATA__DIR,
+ help = CliStrings.EXPORT_DATA__DIR__HELP) String dirPath,
@CliOption(key = CliStrings.MEMBER, optionContext =
ConverterHint.MEMBERIDNAME,
- mandatory = true, help = CliStrings.EXPORT_DATA__MEMBER__HELP)
String memberNameOrId) {
+ mandatory = true, help = CliStrings.EXPORT_DATA__MEMBER__HELP)
String memberNameOrId,
+ @CliOption(key = CliStrings.EXPORT_DATA__PARALLEL,
unspecifiedDefaultValue = "false",
--- End diff --
also, since there is a unspecified default value (false), is it really
necessary to make it a mandatory option if "dir" is specified? can we just make
it default to false(or true, whatever sensible) if user didn't add --parallel,
but specified --dir?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
