-1 without the examples. We *could* theoretically be releasing the examples separately, but that's not our current release process. The release steps include releasing the examples - https://cwiki.apache.org/confluence/display/GEODE/Release+Steps.
I don't think the examples release needs to wait for the outstanding PRs, unless any of those are critical for 1.3.0? -Dan On Tue, Oct 17, 2017 at 11:20 AM, Swapnil Bawaskar <sbawas...@pivotal.io> wrote: > Since geode-examples is a separate repo, I would think that it enables us > to release independently. Can you elaborate on why not including examples > makes it -1 for you? > > Yes, I will update geode-examples to expect a tgz filename before cutting a > 1.3.0 release of examples. > > On Sun, Oct 15, 2017 at 8:52 PM Anthony Baker <aba...@pivotal.io> wrote: > > > -1 > > > > The geode-examples source should be included in this release. > > > > The download task in the geode-examples build also needs to be updated > > since the distribution archive name has changed from .tar.gz to .tgz. > Are > > there any other downstream dependencies affected by this change? > > > > Anthony > > > > > > > On Oct 13, 2017, at 1:39 PM, Swapnil Bawaskar <sbawas...@pivotal.io> > > wrote: > > > > > > This is the second release candidate for Apache Geode, version 1.3.0. I > > > will send out a separate vote thread for geode-examples. > > > Thanks to all the community members for their contributions to this > > > release! > > > > > > *** Please download, test and vote by Monday, October 16, 0800 hrs > > > US Pacific. *** > > > > > > It fixes 376 issues. release notes can be found at: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12318420&version=12340669 > > > > > > Note that we are voting upon the source tags: rel/v1.3.0.RC2 > > > https://github.com/apache/geode/tree/rel/v1.3.0.RC2 > > > > > > Commit ID: > > > 9e076738fc2ae40f95bd179b5c1624e664a28d61 > > > > > > Source and binary files: > > > https://dist.apache.org/repos/dist/dev/geode/1.3.0.RC2 > > > > > > Maven staging repo: > > > https://repository.apache.org/content/repositories/orgapachegeode-1033 > > > > > > Geode's KEYS file containing PGP keys we use to sign the release: > > > https://github.com/apache/geode/blob/develop/KEYS > > > > > > Release Signed with Key: pub 4096R/18F902DB 2016-04-07 > > > Fingerprint: E1B1 ABE3 4753 E7BA 8097 4285 8F8F 2BCC 18F9 02DB > > > > >
