I’m confused about which source tag we are voting on. ~/code/incubator-geode ((rel/v1.3.0.RC3))$ git tag -v rel/v1.3.0.RC3 object 59f2a73d108101744ed7b2d88e8d1c948d19781c type commit tag rel/v1.3.0.RC3 tagger Swapnil Bawaskar <sbawas...@apache.org> 1508355792 +0530
Release candidate 3 for 1.3.0 gpg: Signature made Wed Oct 18 12:43:21 2017 PDT gpg: using RSA key 8F8F2BCC18F902DB gpg: Good signature from "Swapnil Bawaskar <sbawas...@apache.org>" [full] This is different than the commit sha in the vote request. Also, the source and binary distributions appear to have been generated from different sha’s? ~/working$ ./apache-geode-1.3.0/bin/gfsh version --full | grep Revision Source-Revision: 9e076738fc2ae40f95bd179b5c1624e664a28d61 ~/working$ ./apache-geode-1.3.0-src/geode-assembly/build/install/apache-geode/bin/gfsh version --full | grep Revision Source-Revision: 59f2a73d108101744ed7b2d88e8d1c948d19781c Voting -1 based on this discrepancy. Other notes: - builds from source - binary distribution works - geode-examples builds from source - no binaries in source distribution - we should update the geode-examples distribution filename to ‘tgz’ to match the geode distribution in the next release Anthony > On Oct 18, 2017, at 1:51 PM, Swapnil Bawaskar <sbawas...@pivotal.io> wrote: > > This is the third release candidate for Apache Geode, version 1.3.0. > Thanks to all the community members for their contributions to this > release! > > *** Please download, test and vote by Monday, October 23, 0800 hrs > US Pacific. *** > > It fixes 376 issues. release notes can be found at: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420&version=12340669 > > Note that we are voting upon the source tags: rel/v1.3.0.RC3 > https://github.com/apache/geode/tree/rel/v1.3.0.RC3 > https://github.com/apache/geode-examples/tree/rel/v1.3.0.RC3 > > Commit ID: > 9e076738fc2ae40f95bd179b5c1624e664a28d61 (geode) > 4ff8f8eafd0927888e711ee45d283ab07d345000 (geode-examples) > > Source and binary files: > https://dist.apache.org/repos/dist/dev/geode/1.3.0.RC3 > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachegeode-1034 > > > Geode's KEYS file containing PGP keys we use to sign the release: > https://github.com/apache/geode/blob/develop/KEYS > > Release Signed with Key: pub 4096R/18F902DB 2016-04-07 > Fingerprint: E1B1 ABE3 4753 E7BA 8097 4285 8F8F 2BCC 18F9 02DB