+1 for removing both CliStrings and LocalizedStrings
> On Oct 20, 2017, at 2:28 PM, Jinmei Liao <jil...@pivotal.io> wrote:
>
> +1 for removing it.
>
> On Fri, Oct 20, 2017 at 2:04 PM, Jared Stewart <jstew...@pivotal.io> wrote:
>
>>
>>> On Oct 20, 2017, at 1:59 PM, Dan Smith <dsm...@pivotal.io> wrote:
>>>
>>> +1 for removing it.
>>>
>>> I do think it would be nice if we add localization in the future. But
>>> I don't really like the idea of leaving stuff in our code just in case
>>> we decide to implement a feature in the future - we might not even
>>> want what we left in there! In this case even with localization we
>>> might want to move these constants into their specific command classes
>>> anyway - the constant might just look up the localized string instead
>>> of being hardcoded.
>>>
>>> -Dan
>>
>> Totally agree with this reasoning, I’m a firm believer in the YAGNI
>> principle. (https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it <
>> https://en.wikipedia.org/wiki/You_aren't_gonna_need_it>)
>>
>> - Jared
>
>
>
>
> --
> Cheers
>
> Jinmei
