Hi Dave, I got the same code review comment as your second point (—include-locators to be defaulted to true when the option is provided without value) and I am incorporating that comment.
Thanks, Srikanth > On Oct 23, 2017, at 11:51 AM, Dave Barnes <dbar...@pivotal.io> wrote: > > Swapnil, > Are you suggesting that the gfsh shutdown command should shut down locators > by default, not just data members? Sounds to me like a breaking change. > If you area suggesting that the --include=locators option, when specified, > should be accepted without the "=true" bit, which is now mandatory, I agree. > > On Mon, Oct 23, 2017 at 3:04 AM, Swapnil Bawaskar (JIRA) <j...@apache.org> > wrote: > >> >> [ https://issues.apache.org/jira/browse/GEODE-3843?page= >> com.atlassian.jira.plugin.system.issuetabpanels:comment- >> tabpanel&focusedCommentId=16214921#comment-16214921 ] >> >> Swapnil Bawaskar commented on GEODE-3843: >> ----------------------------------------- >> >> All gfsh command options have a default value. In this case the default >> value should be made true (if it is not already) rather than trying to fix >> the message. >> >>> gfsh shutdown error message suggests non-existent option >>> -------------------------------------------------------- >>> >>> Key: GEODE-3843 >>> URL: https://issues.apache.org/jira/browse/GEODE-3843 >>> Project: Geode >>> Issue Type: Bug >>> Components: gfsh >>> Reporter: Dave Barnes >>> Assignee: Srikanth Manvi >>> Priority: Minor >>> >>> 1. Start gfsh. >>> 2. Start a locator. >>> 3. Issue the 'shutdown' command. >>> gfsh prompts for 'do you really want to...', then issues an error >> message alerting you to the lack of data nodes. OK so far. >>> This is followed by a line recommending that you use >> '--shutdown-locators' to stop your locator. >>> Should be '--include-locators=true'. >> >> >> >> -- >> This message was sent by Atlassian JIRA >> (v6.4.14#64029) >>
