For geode-examples I think it makes sense that they are on released with geode (which they are, see https://cwiki.apache.org/confluence/display/GEODE/Release+Steps). We are currently adding examples for features that will be available in geode 1.4, so we want those to be released in sync with geode 1.4.The geode-examples are not in separate repo to have a separate release cycle. They are in a separate repo to make it easy for someone to just clone the example source and start using it.
Back to the original question - we've been trying to make sure the java examples in geode-examples get compiled and run as part of the travis build for the geode-examples repo. Any PR for the geode-examples repo goes through that travis build. I think the C# examples also need compile and run otherwise they will rot and be hard to maintain. If it's too hard to get them to compile as part of geode-examples, moving them into geode-native and building them as part of that build process seems like a good start. -Dan On Mon, Oct 23, 2017 at 11:09 AM, Anilkumar Gingade <aging...@pivotal.io> wrote: > In line with geode-core and geode-examples any thoughts about having > geode-native-examples (on its own repo)... > > -Anil. > > > On Mon, Oct 23, 2017 at 9:18 AM, Jacob Barrett <jbarr...@pivotal.io> > wrote: > > > On Fri, Oct 20, 2017 at 6:02 PM Dan Smith <dsm...@pivotal.io> wrote: > > > > > However I do think we should be compiling (and hopefully running!) > > > these examples so that they don't rot over time. Especially since I > > > believe we are still evolving the native API with breaking changes and > > > have not actually managed a release for the native code yet? > > > > > > > If someone in the community has the bandwidth to setup a windows jenkins > > build the system requirements and instructions are in the geode-native > > README.md. There is a very specific set of toolkit needed to build Geode > > Native. After getting Native building you will need to find a way to > update > > the csproj files with the path to the Apache.Geode.dll before building > the > > examples solution. I would recommend CMake for that process but a simple > > sed replacement works too. > > > > One option if it is too hard to automate the build of these things in > > > geode-examples is that we could put them into geode-native until we > > > actually release geode-native. > > > > > > I think it is just fine keeping them where they are. I have very strong > > reservations about treating the geode-examples repo as some blessed and > > released repository. If it is that strongly coupled with the Geode > release > > then it should have never been moved to its own repo. Geode Native was > put > > in its own repo to allow Geode Native to develop and release on an > > independent cycle than that of the Geode server and java client. The same > > rational was used to support the creation of geode-examples repo. This > > should be a living and breathing ground for community based examples. If > > ware going to treat it as product and product that is tied to the geode > > repo then those components should be moved to the geode repo. > > > > If the community disagrees then I will gladly move the native examples > out > > of geode-examples. > > > > -Jake > > >
