Ok I’m calling this one closed. We are going to drop the exceptions map and change the function to return the entry map only.
> On Oct 23, 2017, at 11:53 AM, Mark Hanson <mhan...@pivotal.io> wrote: > > +1 for dropping the exceptions map. >> On Oct 23, 2017, at 10:36 AM, Ernest Burghardt <eburgha...@pivotal.io> wrote: >> >> +1 drop exceptions map >> >> On Mon, Oct 23, 2017 at 10:53 AM, Michael William Dodge <mdo...@pivotal.io> >> wrote: >> >>> +1 for dropping the exceptions map for symmetry with the Java API >>> >>> Sarge >>> >>>> On 23 Oct, 2017, at 09:32, Jacob Barrett <jbarr...@pivotal.io> wrote: >>>> >>>> As part of our decision to replace all function out variables with return >>>> values we ran into an interesting function with Region::getAll. That >>>> function had two out variables, one the map of key/value pairs and >>> another >>>> map for key/exception pairs. There are no tests that actually test the >>>> key/exception pair nor does it match any API on the Java client. The best >>>> we can figure is that it was a half baked extension to the API. >>> Converting >>>> to return values means that getAll must return a std::tuple and while >>> this >>>> is within our decision guidelines it feels really dirty on this function. >>>> >>>> I propose that we drop the exceptions map from the return of >>>> Region::getAll. Please respond in the next 48 hours with our input on >>> this >>>> matter. >>>> >>>> -Jake >>> >>> >
