-0. Code looks good to me and it passes geode-release-check. But I'd really like to see some people who have worked on the native code sign off on this release. We haven't released the native code before, and I don't know how to validate it other than just to see that it compiles, which doesn't say much. If we get a few +1s from those folks, than I'll be a +1 as well!
-Dan On Mon, Dec 10, 2018 at 4:41 PM Ryan McMahon <rmcma...@pivotal.io> wrote: > +1 > > - Ran all examples > - Ran gfsh, created region, performed basic entry operations > - Verified SHAs > - Verified signatures > > Ryan > > On Mon, Dec 10, 2018 at 4:01 PM Alexander Murmann <amurm...@pivotal.io> > wrote: > > > A reminder for everyone that the vote is scheduled to end tonight. Please > > verify and vote! > > > > @Galen I'll take a look and fix the handwritten note. > > >
