The 1.7.0 version of publish.gradle had stuff like:
extraArchive {
sources = true
javadoc = true
tests = false
}
and
afterEvaluate {
// uses the tasks created by nexus for sources and javadoc
if (!getTasksByName('sourcesJar', false).isEmpty()) {
artifact sourcesJar
}
if (!getTasksByName('javadocJar', false).isEmpty()) {
artifact javadocJar
}
That caused the sources + java doc to be published to maven. There’s an
example at [1] that shows how to do this with the new plugin.
Anthony
[1] https://docs.gradle.org/current/userguide/publishing_maven.html
<https://docs.gradle.org/current/userguide/publishing_maven.html>
> On Dec 21, 2018, at 1:07 PM, Owen Nichols <[email protected]> wrote:
>
> Maybe I misunderstand what happened. It sounded like the problem was
> essentially just “forgot to upload some docs”. If it’s more than that, then
> in addition to 1.8.1 do we need to take any steps to retract 1.8.0 as DOA?
>
>
>> On Dec 21, 2018, at 12:59 PM, Alexander Murmann <[email protected]> wrote:
>>
>> Owen, changing what's in a particular version of a library after it has
>> been shipped to me breaks the contract established by the version number,
>> regardless of how minor the changes are.
>>
>> On Fri, Dec 21, 2018 at 12:04 PM Owen Nichols <[email protected]> wrote:
>>
>>> My feeling is that a 1.8.1 is not the right response. If we can put the
>>> missing jars in place manually for 1.8.0 that should be sufficient.
>>>
>>> -Owen
>>>
>>>> On Dec 21, 2018, at 9:16 AM, Alexander Murmann <[email protected]>
>>> wrote:
>>>>
>>>> I confirmed what we upload to the Nexus staging site again with both 1.7
>>>> and 1.8. I think we must have stopped uploading these files when we
>>>> switched to the maven-publish plugin as part of GEODE-5597.
>>>>
>>>> Can someone who worked on the recent build changes please take a look? I
>>>> created GEODE-6235 to track this.
>>>>
>>>> This to me seems like it would warrant a 1.8.1 patch release. What do you
>>>> all think?
>>>
>>>
>
