Sounds good. +1 to failing the build if new warnings are introduced.

-Dan

On Tue, Jan 15, 2019 at 12:59 PM Galen O'Sullivan <gosulli...@pivotal.io>
wrote:

> I'm for failing CI on warnings. It would be nice to reduce or eliminate our
> existing build warnings as well.
>
> Thanks,
> Galen
>
>
> On Tue, Jan 15, 2019 at 12:33 PM Peter Tran <pt...@pivotal.io> wrote:
>
> > Hello!
> >
> > I've noticed that there is no mechanism in which we prevent new PRs from
> > introduce new build warnings. In our PR template we ask people to self
> > report that they have a "clean build" but nothing more to ensure we're
> not
> > adding new warnings.
> >
> > Has there been an initiative to address this in the past? Would it be too
> > restrictive if CI fails if new warnings are introduced in a PR?
> >
> > Thanks
> > --
> > Peter Tran
> >
>

Reply via email to