Feedback seems to be positive, I'll go ahead and merge this. I'll create a separate PR to split out memcached - I think that is a good idea.
Thanks! -Dan On Tue, Mar 12, 2019 at 5:56 PM Anilkumar Gingade <aging...@pivotal.io> wrote: > +1 > > On Tue, Mar 12, 2019 at 5:32 PM John Blum <jb...@pivotal.io> wrote: > > > Definitely a reasonable change. Perhaps, for consistency sake, the same > > should be applied to Geode's Memcached support? (in another PR). > > > > > > On Tue, Mar 12, 2019 at 4:23 PM Dan Smith <dsm...@pivotal.io> wrote: > > > > > I created a PR to move our redis support to a separate module. Let me > > know > > > what you think: > > > > > > https://github.com/apache/geode/pull/3284 > > > > > > Geode servers will still include redis on the classpath, so the only > > effect > > > of this is that if you are launching a server based on the maven > > > dependencies, you will need geode-core and geode-redis to launch a > server > > > with redis. > > > > > > In addition to making it easier to find the redis specific code this > also > > > removes 4 dependencies from geode-core. > > > > > > -Dan > > > > > > > > > -- > > -John > > john.blum10101 (skype) > > >
