In discussion with Dan, I made a few realizations, so I have new API coming.
Basically dropping the use of InternalCache below. Please hold off on reviewing. Thanks, Mark > On Dec 11, 2019, at 3:34 PM, Mark Hanson <mhan...@pivotal.io> wrote: > > > In Cache.java > > + <K, V> RegionFactory<K, V> createRegionFactory(RegionFactory<K, V> > regionFactory); > > In RegionFactory.java > + public RegionFactory(InternalCache cache, RegionFactory<K, V> regionFactory) > and > + public RegionFactory(RegionFactory<K, V> regionFactory) > > Lastly in GemfireCacheImpl.java > + public <K, V> RegionFactory<K, V> createRegionFactory(RegionFactory<K, V> > regionFactory) > > Thanks, > Mark > > >> On Dec 11, 2019, at 3:25 PM, Dan Smith <dsm...@pivotal.io> wrote: >> >> I see a lot of PR comments on those PRs. What is the new API you added? >> >> -Dan >> >> On Wed, Dec 11, 2019 at 2:57 PM Mark Hanson <mhan...@pivotal.io> wrote: >> >>> Hi All, >>> >>> There was a suggestion that since I am making a couple user visible API >>> changes that I might want to ask the dev list. >>> >>> Basically I was migrating code from AttributesFactory to RegionFactory and >>> hit a few snags along the way. >>> >>> Please see https://github.com/apache/geode/pull/4409 < >>> https://github.com/apache/geode/pull/4409> specifically Cache.java, >>> RegionFactory.java, and for extra credit GemfireCacheImpl.java >>> >>> I have commented at the relevant changes. >>> >>> Thanks, >>> Mark >
