Thanks for the additional context, Udo! That makes a lot of sense. I want to make sure we are very deliberate about including anything but a critical fix in a release branch after it has been cut.
+1 to including Udo's change once we feel confident about the tests On Wed, Feb 5, 2020 at 4:27 PM Jinmei Liao <jil...@pivotal.io> wrote: > Even though the management service is still marketed as "experimental" and > we don't need to go through deprecations, I would still very much prefer > this gets pulled into 1.12 so that users don't have to deal with > experimental public API changes. > > On Wed, Feb 5, 2020 at 4:23 PM Udo Kohlmeyer <u...@apache.com> wrote: > > > @Alexander, I can most certainly elaborate more. > > > > In short, this refactor does not have to be in 1.12, but it does alter > > public Builders and classes. Which means, that if we don't release it > > with 1.12, we would have to go through the cycle of deprecation,etc. to > > get this change in. Given that the initial GEODE-7715 ticket is not in > > any released version of Geode, it would just simplify the process of not > > having to go through unnecessary pain to simplify and make this process > > more intuitive for users. > > > > Does this answer your question as to why? > > > > --Udo > > > > > > On 2/5/20 3:01 PM, Alexander Murmann wrote: > > > Udo, you say "refactor", but this sounds more like a feature or user > > facing > > > improvement. Do you mind elaborating a little more why this should be > in > > > this release? > > > > > > On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson > > <jpatr...@vmware.com.invalid> > > > wrote: > > > > > >> +1 > > >> > > >> On 2/5/20, 1:53 PM, "Udo Kohlmeyer" <u...@apache.com> wrote: > > >> > > >> Hi there Geode dev, > > >> > > >> I would like to request that GEODE-7752 > > >> (7028f601680fee3f57cbdff63951128d7180ca13) gets included into > 1.12. > > >> > > >> This piece of code is a refactor of work done in GEODE-7715. This > > >> refactor specializes Builders and simplifies Builder behavior for > > >> better > > >> user experience. > > >> > > >> --Udo > > >> > > >> > > >> > > >> > > > > > -- > Cheers > > Jinmei >
