DonalEvans commented on issue #4909: URL: https://github.com/apache/geode/pull/4909#issuecomment-617470775
> it seems like there are several classes that are a tweaked copy of existing classes - RestoreRedundancyBuilderImpl, RestoreRedundancyDirector, RegionRedundancyStatus. Is there a way we could extend/generalize the existing classes rather than copy/paste/tweak? I've modified `CompositeDirector` slightly to avoid the need for the `RestoreRedundancyDirector` class, but as described in my comment above, doing the same for `RestoreRedundancyBuilderImpl` would be very difficult at this point. As for `RegionRedundancyStatus`; it's fundamentally very different from `RebalanceResults` in terms of the information it contains, since it represents a snapshot of the state of a region rather than the work done to get it to that state (unless I've missed something here and there is another class that already exists and is similar to `RegionRedundancyStatus`). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
