Excellent, Donal! If you have not already done so, please consider documenting the practice you're advocating in a place where all community contributors have a chance of seeing it. Maybe https://cwiki.apache.org/confluence/display/GEODE/How+to+Contribute?
On Thu, May 28, 2020 at 9:46 AM Donal Evans <doev...@vmware.com> wrote: > I'm happy to say that as of about 5 minutes ago, there are no uses of > hardcoded "/" in region paths/names in the geode codebase, as all of them > have been replaced by the Region.SEPARATOR constant (with the exception of > a few occurrences in the geode-management module, which while not having an > explicit dependency on geode-core has implicit dependencies on some things > like the region separator, index types etc). I'd like to request that going > forward, we maintain this convention of only using Region.SEPARATOR and > avoid introduction of any new hardcoded "/" characters in code pertaining > to region paths or names, both in our own commits and in commits we review > from other developers. >
