Since most folks don't even notice they've been requested to review a PR, I don't have high confidence that they'll notice a notification about a comment on a past commit. Seems sort of useful though. Thank you!
On Thu, Jun 18, 2020 at 3:53 PM Owen Nichols <onich...@vmware.com> wrote: > Perhaps a little-known feature of GitHub: you can comment on commits too, > not just on PRs. For example: > https://github.com/apache/geode/commit/d82e30d3dd50e3983c332063c41915e97aca721a > > On 6/18/20, 3:48 PM, "Kirk Lund" <kl...@apache.org> wrote: > > I'm not sure what you're talking about Jake (PRs?). I'm talking about > commits that are already on develop. > > For example, if someone adds a new dunit test that turns out to be very > flaky, I'd like to find out from the git log who authored it and send > them > an email directly (privately) and I have no way to do that if they're > hiding their email address. > > Thanks though, > Kirk > > On Thu, Jun 18, 2020 at 3:43 PM Jacob Barrett <jabarr...@vmware.com> > wrote: > > > Regardless of the email address issue, you can go to the commit and > make > > comments and @johndoe and they will get a notification. > > > > -Jake > > > > > > > On Jun 18, 2020, at 10:31 AM, Kirk Lund <kl...@apache.org> wrote: > > > > > > I guess my main point is that I don't like private emails in OSS > commit > > > messages. > > > > > > Author: John Doe <john...@users.noreply.github.com> > > > > > > If there's a problem with a commit made by John Doe and he doesn't > work > > for > > > Pivotal, then I have no idea how to contact him directly to > discuss the > > > commit. If I visit github.com/johndoe, there's no way to send a > message > > to > > > Mr. Doe. If Mr. Doe is a committer, then I know john...@apache.org > > exists. > > > > > > Is there really a privacy problem with having "john...@apache.org" > in > > the > > > commit message? Hiding it makes it very difficult for the rest of > us in > > the > > > same community to contact that person which is why I don't like > private > > > emails. > > > > > > Are you getting lots of spam from git commits?? > > > > > > > > > On Wed, Jun 17, 2020 at 1:20 PM Nabarun Nag <n...@vmware.com> > wrote: > > > > > >> Hi Kirk, > > >> > > >> I think it is also now in the privacy setting in GitHub for > anyone who > > >> wants to keep emails private. [ > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Conichols%40vmware.com%7C7ac9167a37b54c070d7e08d813d9aa6e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637281172880655331&sdata=QrtQe4ftMGNQIaf1KOXMuQXDQQAnL4x09Cpa1gW47%2Bs%3D&reserved=0 > > : > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsettings%2Femails&data=02%7C01%7Conichols%40vmware.com%7C7ac9167a37b54c070d7e08d813d9aa6e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637281172880655331&sdata=QrtQe4ftMGNQIaf1KOXMuQXDQQAnL4x09Cpa1gW47%2Bs%3D&reserved=0 > > ] > > >> > > >> This setting is needed for web based git operations like squash > merging > > >> PRs etc. > > >> > > >> In GitHub: > > >> "Keep my email addresses private > > >> We’ll remove your public profile email and use > > >> nabarun...@users.noreply.github.com when performing web-based Git > > >> operations (e.g. edits and merges) and sending email on your > behalf. If > > you > > >> want command line Git operations to use your private email you > must set > > >> your email in Git." > > >> > > >> Regards > > >> Nabarun > > >> > > >> -----Original Message----- > > >> From: Kirk Lund <kl...@apache.org> > > >> Sent: Wednesday, June 17, 2020 1:12 PM > > >> To: dev@geode.apache.org > > >> Subject: Setting your commit email address > > >> > > >> Please make sure you've setup your commit email address. It makes > it > > much > > >> easier to find out who committed something and how to contact > them if > > >> there's a problem. > > >> > > >> You typically use the following to set your email address > globally in > > git: > > >> > > >> $ git config --global user.email "em...@example.com" > > >> > > >> You can also setup different repos with different email addresses > by > > using: > > >> > > >> $ git config user.email "em...@example.com" > > >> > > >> In the below example, it's much easier to follow up with the > author of > > the > > >> 1st commit than the author of the 2nd commit: > > >> > > >> commit b1107d2e403404337c22830a4964eefc2490ef50 > > >> Author: John Doe <j...@pivotal.io> > > >> Date: Tue Jun 16 12:25:30 2020 -0700 > > >> > > >> GEODE-8888: add something new > > >> > > >> commit e159238175766b46cbb6fe1e3459aa2da68db756 > > >> Author: John Doe <john...@users.noreply.github.com> > > >> Date: Tue Jun 16 10:55:16 2020 -0700 > > >> > > >> GEODE-9999: fix something bad > > >> > > >> For more info, see: > > >> > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fhelp.github.com%2Fen%2Fgithub%2Fsetting-up-and-managing-your-github-user-account%2Fsetting-your-commit-email-address&data=02%7C01%7Conichols%40vmware.com%7C7ac9167a37b54c070d7e08d813d9aa6e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637281172880655331&sdata=%2B7D0UrWpNAJeonQ%2Fuu%2F0Em7NTmOfqjBP%2FLP27%2B0Fqzw%3D&reserved=0 > > >> > > >> Thanks, > > >> Kirk > > >> > > > > > >
