Hi Ryan,

Welcome to Geode and thanks for the contribution!

Anthony


> On Feb 9, 2022, at 7:32 AM, Ryan Gardner <ryeb...@gmail.com> wrote:
> 
> Hello,
> 
> Up-front disclaimer: I'm not a Gradle expert - but I spent a little time
> poking around at what it would take to upgrade the build to go from Gradle
> 6.8 -> Gradle 7.4
> 
> Previous efforts to clean up Gradle 7 deprecation warnings made it fairly
> straightforward - in the end it seems there were only a few changes needed.
> 
> - An internal gradle class for the temporary file creation changed it's
> package location in Gradle 7
> - A couple places had references to the now-removed "compile" classpath and
> needed to be replaced with "compileOnly"
> - Gradle 7 gets upset about tasks that have implicit dependencies between
> them - some of the tasks such as the combined report generation needed to
> have a "dependsOn" added to it
> - The Geode build has a custom version of the "DefaultTaskExecutor" -
> Gradle made some minor changes to the DefaultTaskExecutor in version 7.4. I
> made those same changes in the RepeatedTaskExecutor
> 
> On my local machine the build runs the same as it does on the 6.8 version -
> there are some tests that fail due to bind exceptions.
> 
> I just created a draft pull request - like I mentioned before, I'm not the
> world's leading expert in Gradle so there may be a better way to make some
> of the same kind of changes. I created a draft pull request so that it
> might at least serve as a starting point when someone else wants to take a
> look at this.
> 
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7351&amp;data=04%7C01%7Cbakera%40vmware.com%7Cb87399be4fd541cce5a308d9ebe17fab%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C637800176013319812%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=Vu9EguhEg9pFE5Ctiw2%2BkluyGiBVTE23uO5KkEI%2BnrQ%3D&amp;reserved=0
> 
> I didn't see a JIRA issue directly associated with this, it's sort of
> related to GEODE-9161 <https://issues.apache.org/jira/browse/GEODE-9161> since
> it gets rid of the deprecation warnings.
> 
> Hope it's helpful,
> 
> Ryan

Reply via email to