I realize that this is a thread hijack, but hopefully a useful one. I’ve seen several requests for timely reviews in recent months. I think that the CODEOWNERS goals were important and laudable—directing review requests to those most suited to provide oversight—but the implementation has been problematic. The size, complexity, and interconnectedness of the code base meant that many pull requests tagged not just one expert but just about EVERY expert in the community. This is rather inefficient, to say the least.
I propose that we revert CODEOWNERS and return to the review-then-commit model requiring at least one +1 vote from a committer. I see Owen has already created a PR [1] for this change. Thoughts? Anthony [1] https://github.com/apache/geode/pull/7820 > On Jun 28, 2022, at 5:43 AM, Mario Ivanac <mario.iva...@est.tech> wrote: > > ⚠ External Email > > Hi, > > The following PRs: > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7323&data=05%7C01%7Cbakera%40vmware.com%7Cac199366a0df4d162f9c08da5903c883%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637920170037751522%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=83n%2BAmPDOOZbvqp5RYaW06mFU2Cy0azhyhWoIXnFlGE%3D&reserved=0 > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7749&data=05%7C01%7Cbakera%40vmware.com%7Cac199366a0df4d162f9c08da5903c883%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637920170037751522%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tllDC%2Fs0wdCC5Q49tl%2ByQXP%2FzA%2BQT%2B%2Bd2XknHDYBgXk%3D&reserved=0 > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7664&data=05%7C01%7Cbakera%40vmware.com%7Cac199366a0df4d162f9c08da5903c883%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637920170037751522%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JBEIgFD59ZP3JtTQ4mIPFHWKUTjFeskfxvSCkW9momw%3D&reserved=0 > > are waiting for review for some time. > > > Could code owners review these PRs? > > Thanks, > Mario > > ________________________________ > > ⚠ External Email: This email originated from outside of the organization. Do > not click links or open attachments unless you recognize the sender.
