Hi Sai, On Tue, Nov 12, 2024 at 2:28 PM Sai Boorlagadda <sai.boorlaga...@gmail.com> wrote:
> Thanks Sanjay for your contribution. The challenges on testing aren't > broken builds (as far I remember develop should be stable and should have > all tests pass), rather the challenges are that the Distributed Tests are > taking longer than the max timeout allowed (6hrs) on github actions. So as > far as I remember there aren't any failing tests other than that we don't > have ability to run them successfully as the tests demand higher > configuration virtual machines to complete them in a meaningful time. > If we're limited to using only the default GitHub Action runners and our test code is fully optimized, we could consider splitting our tests into groups (such as by package name prefix) and creating multiple workflows to run them in parallel. This way, we can distribute the testing load and potentially speed up the overall CI process. > > > The last commit on development still has a green build (but this is almost > a year old commit). So I triggered a new fresh pipeline and it seems two > WAN related unit tests are failing and not the DiskStoreImpl. > > Ideally we want to investigate these tests and fix them rather than > commenting on them. I will create tickets for the two failing tests in the > WAN submodule, but if you want to take a look here is the pipeline that > runs and reports the failed tests. > > > https://github.com/apache/geode/actions/runs/11787261644/job/32841448763?pr=7887 > > These two tests shouldnt be failing unless there are some commits that > broke this, we should investigate recent commits on development and see if > and which commit has broken these tests and get these tests fixed is my > recommendation but open for other feedback.. > ``` > > WanCopyRegionFunctionServiceTest > > concurrentExecutionsDoesNotExceedMaxConcurrentExecutions() FAILED > org.awaitility.core.ConditionTimeoutException: Assertion condition > defined as a lambda expression in > org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest > expected: 4 > but was: 3 within 5 minutes. > at > org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167) > at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) > at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) > at > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985) > at > org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:769) > at > org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest.concurrentExecutionsDoesNotExceedMaxConcurrentExecutions(WanCopyRegionFunctionServiceTest.java:216) > Caused by: > org.opentest4j.AssertionFailedError: > expected: 4 > but was: 3 > at > sun.reflect.GeneratedConstructorAccessor9.newInstance(Unknown > Source) > at > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at > org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest.lambda$concurrentExecutionsDoesNotExceedMaxConcurrentExecutions$20(WanCopyRegionFunctionServiceTest.java:217) > WanCopyRegionFunctionServiceTest > > severalExecuteWithDifferentRegionOrSenderAreAllowed() FAILED > org.awaitility.core.ConditionTimeoutException: Assertion condition > defined as a lambda expression in > org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest > expected: 5 > but was: 3 within 5 minutes. > at > org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167) > at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119) > at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31) > at > org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985) > at > org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:769) > at > org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest.severalExecuteWithDifferentRegionOrSenderAreAllowed(WanCopyRegionFunctionServiceTest.java:179) > Caused by: > org.opentest4j.AssertionFailedError: > expected: 5 > but was: 3 > at > sun.reflect.GeneratedConstructorAccessor9.newInstance(Unknown > Source) > at > sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at > org.apache.geode.cache.wan.internal.WanCopyRegionFunctionServiceTest.lambda$severalExecuteWithDifferentRegionOrSenderAreAllowed$17(WanCopyRegionFunctionServiceTest.java:180) > > ``` > > > Sai > > > On Sat, 9 Nov 2024 at 09:18, Sanjay Yadav <sky.san...@gmail.com> wrote: > > > I was able to build it after skipping a test which requires review > > withfirst glance. > > Here is pull request with Jira - > > https://github.com/apache/geode/pull/7886 > > > > https://issues.apache.org/jira/browse/GEODE-10455 > > > > Thank You, > > Sanjay Yadav > > > > > > > > On Tue, Oct 22, 2024 at 11:36 AM Sai Boorlagadda < > > sai.boorlaga...@gmail.com> > > wrote: > > > > > I suggest we create a jira for specific change so we can track the > > changes. > > > You can request access to jira and create a ticket yourself to be used > > for > > > your pr. > > > > > > > > > > > > https://issues.apache.org/jira/projects/GEODE/issues/GEODE-7254?filter=allopenissues > > > > > > Sai > > > > > > On Mon, Oct 21, 2024, 10:35 PM Sanjay Yadav <sky.san...@gmail.com> > > wrote: > > > > > > > Thank you Sai Boorlagadda for guidance, links were super helpful. > > > > > > > > I will run all the tests and raise PR if it is small fix, should I > use > > > any > > > > jira as such from my git branch? > > > > > > > > Thank You, > > > > Sanjay Yadav > > > > > > > > On Tue, Oct 22, 2024 at 9:00 AM Sai Boorlagadda < > > > > sai_boorlaga...@apache.org> > > > > wrote: > > > > > > > > > Hi Sanjay, > > > > > > > > > > I would like to understand where you are in setup? Are you able to > > > > checkout > > > > > the code and build? > > > > > > > > > > I would say 'Geode in 5 minutes' is a great start and from there > > > > Testing.md > > > > > shows how to run each tests, while building.md shows how to setup > > > project > > > > > and build in ide such as intellij. > > > > > > > > > > From there you can review github workflows for the ci/CD scripts > > which > > > > > tried to break down distributed tests per each module to be able to > > run > > > > > them parallel. > > > > > > > > > > 1) > > > https://github.com/apache/geode?tab=readme-ov-file#geode-in-5-minutes > > > > > > > > > > 2) https://github.com/apache/geode/blob/develop/TESTING.md > > > > > > > > > > 3) https://github.com/apache/geode/blob/develop/BUILDING.md > > > > > > > > > > On Mon, Oct 21, 2024, 8:18 PM Sanjay Yadav <sky.san...@gmail.com> > > > wrote: > > > > > > > > > > > Hi Kirk/Team, > > > > > > I am new to the ecosystem and would like to help with the above > > > items > > > > > but > > > > > > not sure where to start ? > > > > > > > > > > > > Please discount my naive question ? How can I mirror the > > > > > > environment before raising PR's addressing above ? > > > > > > > > > > > > Thank You, > > > > > > Sanjay Yadav > > > > > > > > > > > > On Tue, Oct 22, 2024 at 4:32 AM Kirk Lund <kl...@apache.org> > > wrote: > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > In my opinion the minimum needed to get Geode PRs flowing so > that > > > > CVEs > > > > > > can > > > > > > > be addressed for a new release: > > > > > > > > > > > > > > - automated build for PRs that has multiple pipelines > > > > > > > 1. compile with unit tests > > > > > > > 2. integration tests per module that depends on compile with > unit > > > > tests > > > > > > > 3. distributed tests per module that depends on compile with > unit > > > > tests > > > > > > > 4. optionally: parallelization of distributed tests for the > > > > geode-core > > > > > > > module > > > > > > > > > > > > > > Automated dependency vulnerability detection and long running > > tests > > > > > with > > > > > > > random killing of servers along with adding new servers into a > > > > cluster > > > > > > > would both be nice to have and very welcome additions but not > > > > required > > > > > > just > > > > > > > to get things moving again. > > > > > > > > > > > > > > Best, > > > > > > > Kirk Lund > > > > > > > > > > > > > > On Fri, Oct 18, 2024 at 10:34 AM Nabarun Nag > > > > > > > <nabarun....@broadcom.com.invalid> wrote: > > > > > > > > > > > > > > > Hey all, > > > > > > > > > > > > > > > > Glad to see this. > > > > > > > > > > > > > > > > The current needs are at bare minimum : > > > > > > > > - an infrastructure to test existing test for PRs > > > > > > > > - CVE detection > > > > > > > > - a Chaos monkey / Jepsen level of testing. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I believe this is the basic requirements. > > > > > > > > > > > > > > > > Regards > > > > > > > > Naba > > > > > > > > > > > > > > > > On Thu, Oct 17, 2024 at 8:59 PM Sanjay Yadav < > > > sky.san...@gmail.com > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Glad to hear that geode is still active, looking forward to > > > > > > > contributing > > > > > > > > to > > > > > > > > > the geode project and its future. > > > > > > > > > > > > > > > > > > I have worth 18+ years of experience with programming > > software, > > > > > > > Looking > > > > > > > > > forward to a roadmap for the geode or helping putting > > together > > > a > > > > > > > roadmap > > > > > > > > > for the product. > > > > > > > > > > > > > > > > > > > > > > > > > > > Thank You, > > > > > > > > > Sanjay Yadav > > > > > > > > > > > > > > > > > > On Thu, Oct 17, 2024 at 6:35 PM Drew Foulks < > > > dfou...@apache.org> > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Greetings All! > > > > > > > > > > > > > > > > > > > > I look forward to helping out with your Infrastructure > > > needs! > > > > > I've > > > > > > > > also > > > > > > > > > > forwarded this thread to dev@geode so that we can > continue > > > > > > > > > > this conversation "on list" so to speak. > > > > > > > > > > > > > > > > > > > > On Tue, Oct 15, 2024 at 11:27 AM Ruth Suehle < > > > > > ruth.sue...@sas.com> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hey, all! This email is not in replacement of my > request > > > that > > > > > you > > > > > > > all > > > > > > > > > > join > > > > > > > > > > > the Geode mailing lists, but in addition. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > I want to introduce Rich Bowen (whom you all met last > > week > > > on > > > > > our > > > > > > > > > > > meeting), as well as Arnout Engelen from the security > > team > > > > and > > > > > > Drew > > > > > > > > > > Foulks > > > > > > > > > > > from the infra team, who would like to discuss the open > > > > > security > > > > > > > > issues > > > > > > > > > > and > > > > > > > > > > > CI/CD needs. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Ruth > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Cheers, > > > > > > > > > > > > > > > > > > > > Drew Foulks > > > > > > > > > > ASF Infra > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > This electronic communication and the information and any > files > > > > > > > > transmitted > > > > > > > > with it, or attached to it, are confidential and are intended > > > > solely > > > > > > for > > > > > > > > the use of the individual or entity to whom it is addressed > and > > > may > > > > > > > > contain > > > > > > > > information that is confidential, legally privileged, > protected > > > by > > > > > > > privacy > > > > > > > > laws, or otherwise restricted from disclosure to anyone else. > > If > > > > you > > > > > > are > > > > > > > > not the intended recipient or the person responsible for > > > delivering > > > > > the > > > > > > > > e-mail to the intended recipient, you are hereby notified > that > > > any > > > > > use, > > > > > > > > copying, distributing, dissemination, forwarding, printing, > or > > > > > copying > > > > > > of > > > > > > > > this e-mail is strictly prohibited. If you received this > e-mail > > > in > > > > > > error, > > > > > > > > please return the e-mail to the sender, delete it from your > > > > computer, > > > > > > and > > > > > > > > destroy any printed copy of it. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- Best wishes！ CalvinKirs
