To make the review simpler, the only two material changes are below. All of the
rest is/ (should be) duplicate code refactoring or source code formatting
according to the conventions that Anthony sent out earlier.
ManagementAgent
-
- //Find developer REST WAR file
- final String gemfireAPIWar = getGemFireAPIWarLocation(gemfireHome);
+
+ // Find developer REST WAR file
+ final String gemfireAPIWar = agentUtil.getGemFireWebApiWarLocation();
​RestAgent
-
- final String gemfireAPIWar = getGemFireAPIWarLocation(gemfireHome);
- if(gemfireAPIWar == null){
- logger.info("Unable to find GemFire Developer REST API WAR file; the
Developer REST API for GemFire will not be exported and accessible.");
+ final String gemfireAPIWar = agentUtil.getGemFireWebApiWarLocation();
+ if (gemfireAPIWar == null) {
> On May 5, 2015, at 10:27 AM, wwilliams-pivotal <g...@git.apache.org> wrote:
>
> GitHub user wwilliams-pivotal opened a pull request:
>
> https://github.com/apache/incubator-geode/pull/2
>
> Allow REST web API to be launched. Eliminate duplicate code
>
> - Refactored duplicate code into a common class
> - Changed the return for the web rest dev api to return gemfire-web-api
> instead of gemfire-web
> - Applied standard formatting conventions against the existing classes per
> code policy
> - Added unit test to check for existence of gemfire-web-api jar
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/wwilliams-pivotal/incubator-geode master
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/incubator-geode/pull/2.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #2
>
> ----
> commit d07af24d1bb3f7c761711b174fe4c30b90d69864
> Author: Wes Williams <wwilli...@pivotal.io>
> Date: 2015-05-05T03:11:04Z
>
> Allow REST web API to be launched. Eliminate duplicate code
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
