I think it would be nice to have infrastructure that can automatically run tests on a pull request.
The current test suite for geode is fairly small because we didn't get the majority of the tests into the initial commit of geode. Those tests should be available in not too long to be merged into geode. Assuming the community wants the tests to be a requirement for committing (I'm strongly in favor of that!), then running the tests will take hours. That may be a burden on someone developing on a laptop without access to other hardware. -Dan On Tue, May 5, 2015 at 3:37 PM, William Markito <wmark...@pivotal.io> wrote: > Some details are already here: > > > https://cwiki.apache.org/confluence/display/GEODE/Criteria+for+Code+Submissions > > On Tue, May 5, 2015 at 3:34 PM, William Markito <wmark...@pivotal.io> > wrote: > > > Hi Ashvin, > > > > That's indeed part of a bigger discussion regarding governance model, > > review process and criteria for PR's. > > > > This get discussed and proposed, but my understanding is that indeed > there > > will be a process that after reviewed and accepted, these changes will go > > into the nightly builds and if they break the build it will generate a > new > > JIRA to track what happened and fix the issues. > > > > It's part of the committer responsibility to run such tests before > > actually committing and the review process can ensure that prior to > accept > > the PR. > > > > > > > > On Tue, May 5, 2015 at 9:56 AM, Ashvin A <aas....@gmail.com> wrote: > > > >> Hi, > >> > >> We are working on finalizing the dev process and I may be jumping on > this > >> question sooner. If so, please ignore my mail. > >> > >> I saw a couple of pull requests today. As a committer, how will I know > if > >> the contributor has executed all the unit tests and the patch is well > >> tested? Will the infrastructure automatically reject the change if it > >> breaks the build? > >> > >> Thanks ! > >> Ashvin > >> > > > > > > > > -- > > > > William Markito Oliveira > > Enterprise Architect > > *http://www.pivotal.io/ <http://www.pivotal.io/>* > > For prompt responses to questions on GemFire/GemFireXD, please write to > *rtds-dev-ea > > at pivotal.io <http://pivotal.io>* > > > > > > -- > > William Markito Oliveira > Enterprise Architect > *http://www.pivotal.io/ <http://www.pivotal.io/>* > For prompt responses to questions on GemFire/GemFireXD, please write > to *rtds-dev-ea > at pivotal.io <http://pivotal.io>* >
