On Mon, May 11, 2015 at 7:31 AM, Anthony Baker <[email protected]> wrote:
> Roman, thanks for laying out these steps! Comments below… > > Once a reviewer gives a thumbs on the change are you suggesting that the > final patch get attached to the JIRA? I’d rather see a commit hash to link > the actual change to the ticket. The review comments would be archived in > reviewboard or on the dev list for GH right? > > > > > 8. Once I get the required +1 I'm going to push to the master > > branch. That will close the PR #1 automagically (because my > > commit message has closes #1 test in it) but I will still have > > to close the JIRA manually once I see that fix made it. > > > > Is there auto-magik integration for JIRA as well? Such as described in > > > https://confluence.atlassian.com/display/JIRACLOUD/Processing+JIRA+issues+with+commit+messages > < > https://confluence.atlassian.com/display/JIRACLOUD/Processing+JIRA+issues+with+commit+messages > > > +1 for updating JIRA from the commit message. I think a JIRA should link to the commit that fixed the JIRA. It would be nice if that happened automatically. Atlassian looks like they have an integration with github, but we probably want to make sure the JIRA links back to the ASF gitweb, so we might have to write our own hook. -Dan
