Part of the urgency is that we now have nightly artifacts that are not easily consumable.
On top of that, I see no reason to hold up anything in the Apache project because of a commercial product requirements. The way you explained your refactoring sounds like it benefits a commercial product. Am I getting this wrong? Thanks, Roman. On Fri, May 15, 2015 at 11:08 AM, John Blum <[email protected]> wrote: > I am in the process of refactoring GemFire's (8.0, 8.1 and 8.2) Maven POM > files now (along with juggling 5 other things). > > What is this exactly holding up (what's the urgency)? I don't see an issue > with delaying this PR until it is properly reviewed. An improper POM file > does cause issues for "consumers". > > I should be able to get to this by EOD. > > Thanks! > John > > > On Fri, May 15, 2015 at 10:30 AM, Roman Shaposhnik <[email protected]> > wrote: > >> Big +1 to that. Commit early commit often. We can always >> change it later if needed too. >> >> Thanks, >> Roman. >> >> On Fri, May 15, 2015 at 8:01 AM, Anthony Baker <[email protected]> wrote: >> > John, have you had a chance to review Mark’s change and the generated >> POM? I think that we could address updates to library versions through a >> follow up issue. >> > >> > Anthony >> > >> >> On May 13, 2015, at 10:22 AM, John Blum <[email protected]> wrote: >> >> >> >> Mark, >> >> >> >> I plan on working on cleaning up the GemFire Maven POM today for 8.0.0, >> >> 8.1.0 and 8.2.0, and we need to make sure that Apache Geode's Maven POM >> >> matches or is similar to clean up the other issues that *Andy Wilkinson* >> >> <https://github.com/spring-projects/spring-boot/issues/2884> [0] sited. >> >> >> >> Please hold off on the commit until I get the chance to review. >> >> >> >> Thanks, >> >> John >> >> >> >> >> >> On Wed, May 13, 2015 at 10:17 AM, Mark Bretl <[email protected]> wrote: >> >> >> >>> Hi All, >> >>> >> >>> I have tried to follow the email threads on the review process, not >> exactly >> >>> sure what to do in this case. I am requesting review of GEODE-23 and my >> >>> patch is attached to the JIRA. It is a one line change which removes >> Spring >> >>> Data GemFire from the Maven POM. >> >>> >> >>> I would like to use a 72 hour lazy consensus. >> >>> >> >>> Best Regards, >> >>> >> >>> -- >> >>> Mark Bretl >> >>> Software Build Engineer >> >>> Pivotal >> >>> 503-533-3869 >> >>> www.pivotal.io >> >>> >> >> >> >> >> >> >> >> -- >> >> -John >> >> 503-504-8657 >> >> john.blum10101 (skype) >> > >> > > > > -- > -John > 503-504-8657 > john.blum10101 (skype)
