----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34814/#review85914 -----------------------------------------------------------
Attached patch 0002 to https://issues.apache.org/jira/browse/GEODE-38 Three changes o- Correcting code format for diffs for original files and full file for new files. o- Renamed unit tests to match expected naming o- Reset system properties to original values following tests - Neil Stevenson On May 29, 2015, 3:39 p.m., Roman Shaposhnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34814/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 3:39 p.m.) > > > Review request for geode. > > > Bugs: GEODE-38 > https://issues.apache.org/jira/browse/GEODE-38 > > > Repository: geode > > > Description > ------- > > Gfsh launcher script implies an init file can be used. This was possible in > GF 6.6, but wasn't implemented in the transition to the new Gfsh in GF 7.0 > onwards. > From "gemfire-assembly/src/main/dist/bin/gfsh.bat " : > " > # > Copy default .gfshrc to the home directory. Uncomment if needed. > # > #if [ ! -f $HOME/.gemfire/.gfsh2rc ]; then > cp $GEMFIRE/defaultConfigs/.gemfire/.gfsh2rc $HOME > #fi > " > If this file is specified, it is currently ignored. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/Gfsh.java > d9a396a > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/GfshConfig.java > d7dba5a > > gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshConfigInitFileTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/shell/GfshInitFileTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/34814/diff/ > > > Testing > ------- > > > Thanks, > > Roman Shaposhnik > >
