> On July 13, 2015, 4:20 p.m., Kirk Lund wrote: > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionedRegionLoadModelJUnitTest.java, > > line 52 > > <https://reviews.apache.org/r/36414/diff/1/?file=1008812#file1008812line52> > > > > This looks more like an IntegrationTest because it spans so many > > packages and real (non-mocked) collaborators. Another good rule of thumb is > > UnitTest should complete in less than 1/10th second.
This test is really only a PartitionRegionLoadModel. CompositeDirector has been refactored out of that class since the test was written, that maybe could be tested separately. Other than that, I'm not sure which collobarators you are talking about. InternalDistributedMember? The test takes 1.3 second run by itself, and most of that type appears to be a dns lookup creating the first inet address. After that the tests cases < 1ms. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36414/#review91476 ----------------------------------------------------------- On July 14, 2015, 1:13 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36414/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 1:13 a.m.) > > > Review request for geode, Darrel Schneider and Hitesh Khamesra. > > > Repository: geode > > > Description > ------- > > Tasks submitted to background threads to trigger redundancy > satisfaction. After the satisfy redundancy phase is done we wait for the > tasks to finish. > > The number of buckets that can be recovering in parallel is controlled > by the system property gemfire.MAX_PARALLEL_BUCKET_RECOVERIES, currently > set to 8. > > If a redundancy recovery/rebalance is restarted due to a membership > change, wait for any in progress operations to complete before fetching > new information from all of the members. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/PartitionRebalanceDetailsImpl.java > da67a837f29d426ccb568a74cdd42a2810f7a084 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionedRegionRebalanceOp.java > 7b231ff71d119bd5678a956b92115d1ed9f9d0f4 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/BucketOperator.java > 3c62c7b9d4a5ed2e4c2dbd59e3980ffe3f258ead > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/ParallelBucketOperator.java > PRE-CREATION > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/PartitionedRegionLoadModel.java > 45b7a1fb69b2f8c7d8159205b9d97fb4ccfd0dee > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/SatisfyRedundancy.java > 0f41b2e655896113309edbc65bcb63a91dc7e2dd > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/SatisfyRedundancyFPR.java > 36989f6d7e74fa2a59f5b4817b43382957a95c38 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/rebalance/SimulatedBucketOperator.java > fb8d331be8733bb676dde48ad758e5ddd9f05cae > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java > a80cb9bdcbac800ab39b722a25480a59f81dd1c2 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionedRegionLoadModelJUnitTest.java > d1ea4927105e7c80686ec755a907dbf12d2c021d > > Diff: https://reviews.apache.org/r/36414/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
