----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36533/#review92819 -----------------------------------------------------------
Ship it! Ship It! - Kirk Lund On July 16, 2015, 12:11 a.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36533/ > ----------------------------------------------------------- > > (Updated July 16, 2015, 12:11 a.m.) > > > Review request for geode and Kirk Lund. > > > Bugs: GEODE-128 > https://issues.apache.org/jira/browse/GEODE-128 > > > Repository: geode > > > Description > ------- > > Slowdown was caused by the test hook EXPIRY_UNITS_MS not being set > to true on a BucketRegion. BucketRegion does all the expiration on > a PR. The test was setting it on the bucket's parent but not no the > bucket itself. Bucket's now defer to their parent when initializing > this final field. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 02becb968eb5bd2d18029f905a0c0ce5f7c46d20 > gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java > 8b22db8353dab81ab5c38cc1b95cd139b548d5e0 > > Diff: https://reviews.apache.org/r/36533/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
