----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36855/#review93180 -----------------------------------------------------------
Ship it! Ship It! - Dan Smith On July 27, 2015, 8:15 p.m., Mark Bretl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36855/ > ----------------------------------------------------------- > > (Updated July 27, 2015, 8:15 p.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-160 > https://issues.apache.org/jira/browse/GEODE-160 > > > Repository: geode > > > Description > ------- > > In order to find out if the working directory is a Git workspace, the build > tries to find the '.git' directory and then assumes it is a Git workspace > with a working git executable command. > > The logic is flawed and the build can use the git command 'git rev-parse > --is-inside-working-tree' to figure out both if it has a working git > executable and if it is inside a Git workspace. > > > Diffs > ----- > > gemfire-core/build.gradle 6b8a1df > > Diff: https://reviews.apache.org/r/36855/diff/ > > > Testing > ------- > > Tested building with using Git checkout and outside Git workspace using git > archive > > > Thanks, > > Mark Bretl > >
