This PR looks good to me. Someone want to give me a +1 and I'll merge it in?
-Dan On Tue, Jul 28, 2015 at 10:54 AM, levivic <g...@git.apache.org> wrote: > GitHub user levivic opened a pull request: > > https://github.com/apache/incubator-geode/pull/12 > > Added UnclosableInputStream for SAX parser > > This fix is to solve the issue 135 regarding using IBM JAVA. > > The API doc > http://java.sun.com/javase/6/docs/api/org/xml/sax/InputSource.html for > the SAX InputSource says: "... standard processing of both byte and > character streams is to close them on as part of end-of-parse cleanup, so > applications should not attempt to re-use such streams after they have been > handed to a parser." > > However, the original geode code intentionally tries to reset the > inputstream after parse. In order to block the parser from closing the > stream, we wrap the InputStream in a filter, i.e., UnclosableInputStream, > whose close() function does nothing. > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/levivic/incubator-geode > feature/GEODE-135 > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/incubator-geode/pull/12.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #12 > > ---- > commit 40e3ce9f86616f57a4aebf426b0aa53ba9e0cb0a > Author: lzh <lzh...@ca.ibm.com> > Date: 2015-07-28T17:46:48Z > > Added UnclosableInputStream for SAX parser > > In order to block the parser from closing the stream, we wrap the > InputStream in a filter, i.e., UnclosableInputStream, whose close() > function does nothing. > > ---- > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
