----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37095/#review94128 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/cache/util/BoundedLinkedHashMap.java <https://reviews.apache.org/r/37095/#comment148643> Why did you remove the deprecated javadoc tag? The class is still marked as @Deprecated. Did you know this same class is in com.gemstone.org.jgroups.stack? - Darrel Schneider On Aug. 4, 2015, 2:07 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37095/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 2:07 p.m.) > > > Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, > Jianxia Chen, Lynn Gallinat, William Markito, and Qihong Chen. > > > Repository: geode > > > Description > ------- > > This is a change-set to be pushed to feature/GEODE-77. > > It introduces two-phase view installation when network partition detection is > enabled. > > It also adds quorum checks to view changes and refactors the locator to add a > NetLocator interface, allowing a locator to be booted without an > InternalLocator component for unit testing. > > I also found and fixed problems in the handling of jgroups UUIDs that were > causing multiple UNICAST3 send-channels to be created for each member and > also causing some messages to be rejected by the UDP protocol. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/util/BoundedLinkedHashMap.java > d95c28e > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/Locator.java > 91b6cb6 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DM.java > 4adea7c > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java > a9111b5 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java > 20db1fc > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java > 51203d2 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/direct/DirectChannel.java > c9dc316 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/InternalDistributedMember.java > dd9d6f3 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/MemberFactory.java > 439fb4f > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/MemberServices.java > 3261b08 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/MembershipManager.java > cfca7e8 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetMember.java > 16d3cc5 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetView.java > e6c2b45 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMember.java > 05c5754 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberFactory.java > d07cd2e > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java > 9d9c720 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > b1f5664 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/HealthMonitor.java > 6b268cb > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Manager.java > 315b69f > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java > 902e1f6 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > f94d9c4 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/ViewAckMessage.java > f52811b > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/AddressManager.java > ff03bfd > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGAddress.java > b34b8ed > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java > ec8a0fa > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java > 39685fb > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpClient.java > 6b7eb54 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java > cba5c44 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java > 6298cf6 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/TCPConduit.java > bac9650 > > gemfire-core/src/main/resources/com/gemstone/gemfire/internal/logging/log4j/log4j2-default.xml > 9ab1aa6 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/MembershipJUnitTest.java > 778ba3f > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/MembershipManagerHelper.java > e0a8749 > > Diff: https://reviews.apache.org/r/37095/diff/ > > > Testing > ------- > > The feature/GEODE-77 branch is currently broken but this change set passes a > manual test to start up a locator and two servers with gfsh having network > partition detection enabled and then shut each down with gfsh. Logs show > correct creation of membership views including a preparation phase and then > an installation phase. > > It also passes MembershipJUnitTest. I'm going to run all unit tests but > don't expect any involving HA events or peer authentication to work. > > > Thanks, > > Bruce Schuchardt > >
