----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37316/#review94816 -----------------------------------------------------------
Ship it! Better put the link of the review on JIRA, or put the explanation on JIRA. So that it is easier to track and understand in the future. - Jianxia Chen On Aug. 10, 2015, 9:10 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37316/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 9:10 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Jianxia Chen, > Lynn Gallinat, and Qihong Chen. > > > Repository: geode > > > Description > ------- > > Modified test to use a wait criterion incase the indexes were async for some > reason > Checking for index size instead of local pr size. This should better reflect > the actual number of portfolios that have been deserialized/instantiated. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/CopyOnReadIndexDUnitTest.java > 11cce7e > > Diff: https://reviews.apache.org/r/37316/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
