----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37453/#review95358 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/StatRecorder.java (line 39) <https://reviews.apache.org/r/37453/#comment150272> Is there a chance, where this is not called...We are not doing null checks for "this.stats" in other places. - anilkumar gingade On Aug. 13, 2015, 11:44 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37453/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 11:44 p.m.) > > > Review request for geode, anilkumar gingade, Jason Huynh, Jianxia Chen, and > Qihong Chen. > > > Repository: geode > > > Description > ------- > > This adds the recording of statistics to DistributionStats for the Messenger > component of the membership manager. Old statistics that were being recorded > by the modified JGroups stack have been removed (stats with "JG" in their > names, primarily). > > A new unit test ensures that the stat recorder is in place and is properly > invoking DistributionStats methods. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/StatRecorder.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/StatRecorderJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37453/diff/ > > > Testing > ------- > > New unit test > > > Thanks, > > Bruce Schuchardt > >
