----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37670/#review96028 -----------------------------------------------------------
Ship it! Ship It! - William Markito On Aug. 21, 2015, 3:10 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37670/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 3:10 a.m.) > > > Review request for geode, Darrel Schneider, Eric Shu, and William Markito. > > > Bugs: GEODE-232 > https://issues.apache.org/jira/browse/GEODE-232 > > > Repository: geode > > > Description > ------- > > Bug was introduced when a previous checkin removed two lines in LogService > that were converting the resource string to a URI string for the value of the > log4j.configurationFile system property during initialization. > > The end result is "gfsh prints ERROR StatusLogger log4j2-cli.xml not found in > file system or classpath" > > In these changes, I restore the missing lines and add a bunch of new unit and > integration tests to improve test coverage for LogService and ensure this > does not happen again. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java > a4a399d > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/Configurator.java > ccb2639 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceIntegrationJUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceIntegrationTestSupport.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceJUnitTest.java > ce1b6c2 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceUserDirIntegrationJUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingIntegrationTestSuite.java > 1efaa59 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingUnitTestSuite.java > cd39a9d > > Diff: https://reviews.apache.org/r/37670/diff/ > > > Testing > ------- > > manual testing with gemfire-assembly/build/install/apache-geode/bin/bash > LoggingUnitTestSuite > LoggingIntegrationTestSuite > > > Thanks, > > Kirk Lund > >
