----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37973/#review97473 -----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java (line 408) <https://reviews.apache.org/r/37973/#comment153355> maybe add a check to make sure this flag is false before the remove? gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerJUnitTest.java (line 30) <https://reviews.apache.org/r/37973/#comment153359> Use junit 4 annotations instead of extending TestCase? gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerJUnitTest.java (line 47) <https://reviews.apache.org/r/37973/#comment153358> Would we be able to add comments or a description of what this test is doing? gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerJUnitTest.java (line 74) <https://reviews.apache.org/r/37973/#comment153367> I see we have a few sleeps after a countdown latch. Is there a reason why the latch would be unlocked before the test was ready to continue? - Jason Huynh On Aug. 31, 2015, 11:05 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37973/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 11:05 p.m.) > > > Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, > Jianxia Chen, Lynn Gallinat, and Qihong Chen. > > > Repository: geode > > > Description > ------- > > JaCoCo now shows over 70% code coverage for the new membership service > components from these unit tests alone: > > MembershipJUnitTest > LocatorJUnitTest > GMSLocatorJUnitTest > JGroupsMessengerJUnitTest > GMSHealthMonitorJUnitTest > GMSAuthenticatorJUnitTest > GMSJoinLeaveJUnitTest > > > Coverage: > > GMSAuthenticator - 98% > GMSHealthMonitor - 77% > GMSJoinLeave - 80% > GMSLocator - 77% > JGroupsMessenger - 71% > > AddressManager - 79% > GMSUtil - 77% > Services - 76% > ServiceConfig - 72% > StatRecorder - 79% > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java > 3f8040e > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java > cfda513 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/MemberFactory.java > de469d8 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/MemberServices.java > 9e6c27c > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetView.java > 7b86159 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/GMSMemberFactory.java > 34e1123 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java > dd4ac51 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java > a653110 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/StatRecorder.java > 49dc423 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorJUnitTest.java > db7c217 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocatorJUnitTest.java > e79dcbc > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > cbabc20 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/InterceptUDP.java > aafb466 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java > 515c115 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerJUnitDisabledTest.java > 1cab817 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServerJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37973/diff/ > > > Testing > ------- > > > Thanks, > > Bruce Schuchardt > >
