----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38135/#review97812 -----------------------------------------------------------
Ship it! Ship It! gemfire-core/src/main/java/com/gemstone/gemfire/pdx/internal/TypeRegistry.java (line 125) <https://reviews.apache.org/r/38135/#comment153834> We should be optimizing for info level logging which means not using "if (logger.isInfoEnabled())" It's only worth doing if it's for debug or trace because most people won't run in production with debug or trace. - Kirk Lund On Sept. 4, 2015, 8:50 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38135/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 8:50 p.m.) > > > Review request for geode and Kirk Lund. > > > Bugs: GEODE-311 > https://issues.apache.org/jira/browse/GEODE-311 > > > Repository: geode > > > Description > ------- > > make pdx logging info level > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/pdx/internal/TypeRegistry.java > 4ca1a90725221d1be4ccdc797559276a483b0e60 > > Diff: https://reviews.apache.org/r/38135/diff/ > > > Testing > ------- > > all unit tests > > > Thanks, > > Darrel Schneider > >
