----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38410/#review99106 -----------------------------------------------------------
Take a look at gemfire-assembly. There's some work that needs to go into the distributions closure. Currently you don't see some problems because gemfire-common only includes annotations which are compile-time, not runtime. Essentially, we should mirror everything that is done for gemfire-jgroups. Also, gemfire-common is (eventually) going to be a dependency for every subproject. We can delay adding those for now. - Anthony Baker On Sept. 15, 2015, 9:37 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38410/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 9:37 p.m.) > > > Review request for geode, Anthony Baker, Darrel Schneider, Jacob Barrett, and > Mark Bretl. > > > Bugs: GEODE-328 > https://issues.apache.org/jira/browse/GEODE-328 > > > Repository: geode > > > Description > ------- > > Create new gemfire-common subproject. Add as dependency to gemfire-core, > gemfire-rebalancer, and gemfire-web (should these be removed or kept and > should any others be added?). > > Create new Experimental annotation in gemfire-common. > > Create new unit tests to verify that Experimental can be used to annotate > Interfaces, Classes, Public and Protected Fields, Enums, Enum Constants, > Public and Protected Methods, Packages, and Constructors. > > NOTE: Please review the gradle changes carefully as I'm not as confident > about those. For example, I'm mostly concerned that the javadocs for Geode > might not include Experimental. > > > Diffs > ----- > > gemfire-common/build.gradle PRE-CREATION > > gemfire-common/src/main/java/com/gemstone/gemfire/annotations/Experimental.java > PRE-CREATION > > gemfire-common/src/test/java/com/gemstone/gemfire/annotations/ExperimentalJUnitTest.java > PRE-CREATION > > gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/ClassInExperimentalPackage.java > PRE-CREATION > > gemfire-common/src/test/java/com/gemstone/gemfire/annotations/experimentalpackage/package-info.java > PRE-CREATION > > gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/ClassInNonExperimentalPackage.java > PRE-CREATION > > gemfire-common/src/test/java/com/gemstone/gemfire/experimental/nonexperimentalpackage/package-info.java > PRE-CREATION > gemfire-core/build.gradle 1c17474 > gemfire-rebalancer/build.gradle d87dd58 > gemfire-web/build.gradle b9629d3 > settings.gradle 4b2da7b > > Diff: https://reviews.apache.org/r/38410/diff/ > > > Testing > ------- > > ./gradlew clean build > ./gradlew gemfire-common:test > > > Thanks, > > Kirk Lund > >
