-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38739/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Jason Huynh, Jianxia Chen, and
Lynn Gallinat.
Bugs: GEODE-360
https://issues.apache.org/jira/browse/GEODE-360
Repository: geode
Description
-------
Since it takes pretty much forever to run all of the unit tests I have a number
of fixes bundled into this checkin
if the coordinator returned by locators doesn't work we now
ask other members in the view returned by the locator
leave & crash events now ack the view currently being installed
so that it won't wait for the associated members
views are always installed using the two-phase protocol.
GemFire did this and some algorithms, such as rebalancing,
are thrown off if departed members are in the view when
a rebalance starts.
views are always transmitted by the View Creator thread.
GMSJoinLeave.becomeCoordinator() installs an initial view
into the View Creator before starting it if there is a view
to prepare and install.
Rebalance operations targetting a new member were failing to
achieve balance if an old ID for that member was still in the
membership view. We now detect those old IDs and remove them
when the new member joins.
ClientProxyMembershipID was not being deserialized properly
after being transmitted from one member to another.
HealthMonitor classes with "Ping" in their names are renamed to
"Check". I've found that "Ping" confuses people - they
sometimes think that gemfire is using network ping protocol
HealthMonitor beSick/playDead were tightened up
HealthMonitor was not recording activity from other members unless
it was currently watching that member. This caused a lot of
unnecessary suspicion when switching from one member to another.
HealthMonitor wasn't clear about who was raising suspicion and
who was the target of the suspicion.
FindCoordinatorRequest was using java serialization for rejected
coordinator IDs.
GMSMembershipManager's latestViewLock use wasn't quite the same
as in the membership manager in GemFire 8.2 and caused a deadlock.
fixing GEODE-360: PRTombstoneMessage should ignore
ForceReattemptException
LogFileParser wasn't recognizing timestamps for thread dumps, causing
them to be mis-sorted when merging log files.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java
fdd8092ef9efe2074a6201bfea44352b56c6054f
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java
a14a33248d67715e1e04904f3bbf073d5d1359ab
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java
2158414d1a6ee33db0de6ccc96cf8e88cecb5856
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/MembershipManager.java
85203e2109f6b544902dd47c1fa6c7f6d034829d
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetView.java
b2867db139a622e6f4a3c8358d5a4a2641f43532
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java
c364b4d2e7e31144a0cade8b255683ea94242446
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
ae867d170408bafaf6fca165a1a238a0b9a12721
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/FindCoordinatorRequest.java
da79b03b022e8990ffc2213d4486f572c8c0c876
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/FindCoordinatorResponse.java
e4757962d1f97f4cefcf615b0931eed72bbcf470
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/GMSLocator.java
e0ee678ec1b879c265bcfa41dda11ca8ae7b8eb8
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java
8c5529861e9a7c02a308a848620306cad7b9c3ba
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/InstallViewMessage.java
d8616d0a71917ca384297130ae2fe0092630dcf7
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/LeaveRequestMessage.java
df91a64b360b6c3958070027f6547e9b8835efc1
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/PingRequestMessage.java
a38c586b7d922e21efad885c78f62ab68d0ca61b
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/PingResponseMessage.java
ef69e259527d5ed80d0954719a29055a28b7a70b
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/RemoveMemberMessage.java
30137a24dbe6c866c6aa3e9a7a201a28ca73a0f7
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java
c7c6a192b4d475d745b264d1de434e443b5cf47b
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java
b873154c237f6e20c802726a6fe6478ac77f94e8
gemfire-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java
663f49503cc3f26db103efa1c085f1597751e719
gemfire-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java
12141e03784f1d28eb108f580b4ae6b6eea1c5bd
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PRTombstoneMessage.java
92d7f4db9db8a311094c36aed10b0eea2f63a76c
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java
2cede256f4fd26e46478c459ea5c7ada00161f2f
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientProxyMembershipID.java
e131464e6c206629e4e41881da449d2d99416334
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/ServerConnection.java
b307b95605d5176825b301bc568a6f9d20d2a76c
gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogFileParser.java
23209fa85cb84b1c031ccbfe89285e3e04ad2c13
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java
afd87d4da8dd8723e02428ba7f95d921e8d3cb8e
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/MembershipJUnitTest.java
d261e662427edd2df97fd50d40fe49586fd6fc74
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/MembershipManagerHelper.java
19396f67b2130272de0ce24997ad6acd55dffe44
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSHealthMonitorJUnitTest.java
8910d77de11c17b30efc1b0743117bd0257c15c4
gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
fac9ae87c99037dfd336f3c8c847e9a7c1d83fba
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRFunctionExecutionTimeOutDUnitTest.java
2f45e5f941483e4a9ffd69d9974c856d5c1f3680
gemfire-core/src/test/java/dunit/standalone/DUnitLauncher.java
c21dd727763a7ba522a0efb427b7da538628a913
Diff: https://reviews.apache.org/r/38739/diff/
Testing
-------
all check-in tests. multi-machine tests with lots of HA events.
distributedTest had a few failures that don't seem related to GEODE-77 work.
Thanks,
Bruce Schuchardt
