----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37904/ -----------------------------------------------------------
(Updated Oct. 1, 2015, 10:08 p.m.) Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, Lynn Gallinat, and Qihong Chen. Changes ------- Modified test to actually do a group by. This should fix the issue. The problem before was the test would fail if the ordering of elements in the results differed, however the test was expecting them to be grouped. Repository: geode Description ------- This test is failing intermittently, although this change won't fix the issue, it cleans out some test code and removes a lot of unnecessary debug logging. It also adds additional information when the test fails. Reduced duplicate code and combined comparison logic into common methods Diffs (updated) ----- gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/functional/GroupByTestImpl.java 47c31e2 gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/functional/StructSetOrResultsSet.java 3593db0 Diff: https://reviews.apache.org/r/37904/diff/ Testing ------- Thanks, Jason Huynh
