For Geode in "5 minutes" do we even want to leave the unit tests in? building geode and running unit tests on my laptop took north of 4:30 minutes, just a clean build took 1 minute.
If we removed the unit tests, then we could still have a target "test" for Unit, Integration and DistributionTest. On Thu, Oct 1, 2015 at 2:21 PM, Darrel Schneider <[email protected]> wrote: > +1 > > How about "precheckin" for the target that runs IntegrationTest and > DistributionTest? Perhaps this target should start with a line informing > the runner that it will take hours. > > > On Thu, Oct 1, 2015 at 12:48 PM, Kirk Lund <[email protected]> wrote: > > > Proposal: > > > > 1) Remove IntegrationTest and DistributionTest from "check" target > > > > 2) Add a new target (name TBD) that executes IntegrationTest and > > DistributionTest > > > > Reasons: > > > > 1) new people who clone and then build wait forever and complain that > build > > hung resulting in bad first impression by users > > > > 2) Index-Geodein5minutes instructs user to skip tests but internet wisdom > > says never use -Dskip.tests=true > > > > > > > https://cwiki.apache.org/confluence/display/GEODE/Index#Index-Geodein5minutes > > > > 3) non-developers don't need to run IntegrationTest and DistributedTest > -- > > they just want to clone, build and try out basics to see if they want to > > become a Geode User > > > > 4) anyone who decides they want to become a developer can easily learn > that > > we invoke a target to run the long-running tests -- we can easily > document > > this everywhere if people are truly worried about it > > > > 5) this change encourages us to improve our coverage with fast-running > > UnitTests > > > > Anti-goals > > > > 1) I'm not suggesting that anyone can commit changes without running the > > long-running tests > > > > -Kirk > > >
