----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39028/#review101672 -----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java (line 57) <https://reviews.apache.org/r/39028/#comment159126> I would keep this as an IntegrationTest - Kirk Lund On Oct. 5, 2015, 11:18 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39028/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 11:18 p.m.) > > > Review request for geode and Kirk Lund. > > > Bugs: GEODE-362 > https://issues.apache.org/jira/browse/GEODE-362 > > > Repository: geode > > > Description > ------- > > The test now enables millisecond expiration and uses expiration suspension > and resumption to prevent race conditions. > A test hook was added so that the product will notify the test code when a > particular ExpiryTask has expired. > Since this test now runs in less than a second I changed it from integration > to unit. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java > d5dc5ee31905bae4444c7d5fcf6958eb8cfaa92d > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 617a7ec347cd5648115af66ed5216e7fbc18a3bd > gemfire-core/src/test/java/com/gemstone/gemfire/TXExpiryJUnitTest.java > da9623bee39e44f74c4b5b099d39a07be3a8d172 > > Diff: https://reviews.apache.org/r/39028/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
