----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39110/ -----------------------------------------------------------
Review request for geode, Ashvin A and xiaojian zhou. Repository: geode Description ------- We now have an xsd for the lucene elements, and a LuceneXmlParser service. Geode already has a mechanism to plug in additional xml parsers like LuceneXmlParsers by using the java service loader, which I have done. I've written a LuceneIndexCreation object to match other configuration objects that get generated when a cache is parsed. This creation is attached to regions on index creation time so that when xml is generated, the creation object and generate the appropriate xml snippet. Diffs ----- gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java 60085e45346cdda7e473daf505760eb47a6f7cb8 gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java c2d2ce25d2e46a67edd2e55b85349010374f9a53 gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java 2c4db9d3ad68111acbddbe6b279c1d3a05f2747a gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java PRE-CREATION gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlGenerator.java PRE-CREATION gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneServiceXmlGenerator.java PRE-CREATION gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneXmlConstants.java PRE-CREATION gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneXmlParser.java PRE-CREATION gemfire-lucene/src/main/resources/META-INF/schemas/geode.incubator.apache.org/lucene/lucene-1.0.xsd PRE-CREATION gemfire-lucene/src/main/resources/META-INF/services/com.gemstone.gemfire.internal.cache.xmlcache.XmlParser PRE-CREATION gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlGeneratorIntegrationJUnitTest.java PRE-CREATION gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlGeneratorJUnitTest.java PRE-CREATION gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlParserIntegrationJUnitTest.java PRE-CREATION gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlParserJUnitTest.java PRE-CREATION gemfire-lucene/src/test/resources/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlParserIntegrationJUnitTest.createIndex.cache.xml PRE-CREATION gemfire-lucene/src/test/resources/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlParserIntegrationJUnitTest.parseIndex.cache.xml PRE-CREATION Diff: https://reviews.apache.org/r/39110/diff/ Testing ------- Thanks, Dan Smith
