----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39108/#review101833 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java (line 3961) <https://reviews.apache.org/r/39108/#comment159343> remove then add? gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderAttributes.java (line 77) <https://reviews.apache.org/r/39108/#comment159344> Will there be any backward compatibility issue since we introduce a new attribute here? - xiaojian zhou On Oct. 7, 2015, 11:27 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39108/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 11:27 p.m.) > > > Review request for geode, Ashvin A and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > I added a new flag to the queue - isMetaQueue, which controls whether a > queue will show up in getAllQueues. This also has the effect of > preventing the queue from showing up in a generated xml file. > > This is necessary because our queue needs to be constructed with an > async event listener that has a reference to the index. If the queue is > generated and added to the xml, it will end up trying to create a > listener before the index is created. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java > f41321850f472d0566f89e20104e2420c930140e > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/asyncqueue/internal/AsyncEventQueueImpl.java > 71e8d2a7d617d2542f123706f64a221f58c47163 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java > 6fe639b0daca33ab63e85bfb880dfd20a276513a > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java > 3bd299296844ada13b44b73ead4605b015431726 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderAttributes.java > 1d0b4f111595250b474ce7d2948998bcda9d9f06 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java > 60085e45346cdda7e473daf505760eb47a6f7cb8 > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java > 5ec2725e8f390ac9a3833df0b32c4c8581ab9370 > > Diff: https://reviews.apache.org/r/39108/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
