> On Oct. 8, 2015, 11:48 p.m., Darrel Schneider wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java, > > line 1109 > > <https://reviews.apache.org/r/39149/diff/1/?file=1093374#file1093374line1109> > > > > A comment would be valuable here explaining why it is important for > > this thread to not be a daemon
I should have added the link to the Jira: https://issues.apache.org/jira/browse/GEODE-380 - Jens ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39149/#review101983 ----------------------------------------------------------- On Oct. 8, 2015, 11:17 p.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39149/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2015, 11:17 p.m.) > > > Review request for geode and Bruce Schuchardt. > > > Repository: geode > > > Description > ------- > > GEODE-380 ensure that gfsh shutdown does not leave only daemon threads > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/MemberMBeanBridge.java > b5468688570f77b0474a6b74c68b9713a19c39d5 > > Diff: https://reviews.apache.org/r/39149/diff/ > > > Testing > ------- > > Manual testing performing several thousand shutdown iterations. > > I don't think I'd be able to use DUnit for this as to test the failing case I > need to ensure that all JVM threads end up being daemon threads. > > > Thanks, > > Jens Deppe > >
