----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39159/#review102060 -----------------------------------------------------------
Ship it! Good catch! It might be good to add at test to FileSystemJUnitTest to check for this issue. - Dan Smith On Oct. 9, 2015, 5:11 a.m., Ashvin A wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39159/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 5:11 a.m.) > > > Review request for geode, Dan Smith and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > GEODE-11: Fix index recovery after rebalance > > > Diffs > ----- > > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneQueryImpl.java > a5cbc79c9da23f0b9413024303607fe79c8bda41 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java > 91ad82caab55c1c1b0ee4939c44e70f749a9998f > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/filesystem/FileSystem.java > 50b9f507a3476d87a820cc8e5dc7930128bf646a > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImplJUnitTest.java > 789f2431e885a58c9366db005464c29c92802490 > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneRebalanceJUnitTest.java > PRE-CREATION > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManagerJUnitTest.java > 1225aa1c873b9f7b264e028589b261706a111baf > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionReadPathDUnitTest.java > b37be14826a282591c961ae6d2491350ee987e37 > > Diff: https://reviews.apache.org/r/39159/diff/ > > > Testing > ------- > > On commit, lucene renames checkpoint file. The fileSystem was updating the > file object but not updating it in the fileRegion. Hence the updates were > getting lost. On recovery path, empty file was causing failures. > > GEODE-11: Fix index recovery after rebalance > > > Thanks, > > Ashvin A > >
