> On Oct. 12, 2015, 9:22 p.m., Jianxia Chen wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java, > > line 495 > > <https://reviews.apache.org/r/39178/diff/1/?file=1094092#file1094092line495> > > > > This probably has to be moved to start() function, because the map of > > the socket information Map<InternalDistributedMember, InetSocketAddress> > > need localAddress, once server socket is started in start() function.
I don't have a map of member->inetsocketAddress in my code base. If you need to move it for the tcp/ip checks you should do it in your own checkout. - Bruce ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39178/#review102328 ----------------------------------------------------------- On Oct. 9, 2015, 5:34 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39178/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 5:34 p.m.) > > > Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, > Jianxia Chen, and Lynn Gallinat. > > > Repository: geode > > > Description > ------- > > GMSHealthMonitor was allowing the service to watch itself if it ran out of > other members to watch. This change set modifies that behavior to set the > "next neighbor" to null, causing suspect processing to halt until a member > transitions out of "susupect" state or a new membership view is installed. > > I also found that GMSHealthMonitor wasn't notifying the Manager when a member > goes into final-check state, so that membership listeners weren't being > notified of "suspect" events. This was causing a unit test failure. > > JGroupsMessenger now fools the JGroups stack into thinking an IPv4 stack is > being used even if IPv6 is available, so that JGroups will use an IPv4 > address. JGroups was selecting an IPv6 address, making communications with > IPv4 members impossible and causing a schizm between the GemFire member > address and the JGroups address. > > The JGroups log level is now set to WARN in the default log4j2.xml settings > file. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/admin/internal/InetAddressUtil.java > 3decb8d4292e439e9100f23b7240814d102f8c93 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java > 33d5b80cbf78b3510da78025fa170380a5effb55 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/ServiceConfig.java > d7f722a521220b9f7091d6a4bd71b1a0bdd73af1 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/Services.java > ff0a52ecfd676317b863b0a57a4e465de5c883c9 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/auth/GMSAuthenticator.java > c4b822e1b7ddd2620eb9d4cdd1b490f4f2dcd6cc > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > f108e4974df762457b8ce6f125455b8d5a384eaf > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Manager.java > bd9274e1d38c4496b2c65bec908e21530a36e415 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/interfaces/Service.java > 082ea0afbd40240761fc3506bb0ca2738203b5c2 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/locator/FindCoordinatorResponse.java > 7177d04ce1680c968fa29a6ff3285e6944c1d981 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 3fb86ee902c27e259c6b8b98746234bd23351ee5 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java > a345df1098460af34dee02bd62cc9ea4a812e6aa > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/GMSMembershipManager.java > 14aa10d8218a6fe60c3b1fd64f26e9fd18b8bb35 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/mgr/LocalViewMessage.java > 3b63fb655c63a12e8a47d557165cff0a07c9fb1f > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpServer.java > a859ba654afe7603ef54de858ff916f4e3cf6f80 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/admin/remote/ShutdownAllRequest.java > 242f9694330844f6e1a15d7bc76956e0929c7ace > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/tcp/Connection.java > eaa1b5623f9b4ff548d5862c6bfda65bc09f9a96 > > gemfire-core/src/main/resources/com/gemstone/gemfire/internal/logging/log4j/log4j2-default.xml > e383d0ae497940b9b90cf91516ba1ba09fce3146 > > gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/MultiIndexCreationDUnitTest.java > c3023e7e47457daa070135dcee79d2183a7d5bfe > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java > f44102374e843c00e301740cddad561d14621a6c > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSHealthMonitorJUnitTest.java > bc75d435b18a16094463a1725da1b93afc316661 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java > 83c1419bb854d6ce98df64e4ed90d9c52d68ff08 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/ConnectDisconnectDUnitTest.java > 44ee0a1972a1cd09f5ecf63ad8a5a7c010365375 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/ShutdownAllDUnitTest.java > e08b50784c7b9189b7baecd3b5eda2a61741bbb2 > > Diff: https://reviews.apache.org/r/39178/diff/ > > > Testing > ------- > > unit testing, some external integration testing > > > Thanks, > > Bruce Schuchardt > >
