----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39290/#review102539 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On Oct. 13, 2015, 2:24 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39290/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 2:24 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, and Darrel > Schneider. > > > Bugs: GEODE-189 > https://issues.apache.org/jira/browse/GEODE-189 > > > Repository: geode > > > Description > ------- > > GemFire currently configures Log4J 2 only if it's not already configured. The > new JGroups includes log4j2.xml in the root of the JAR which is on the > classpath. Log4J 2 automatically picks this up and uses it. These change > involve placing the default log4j2.xml for GemFire in the root of the > gemfire-core JAR. If this JAR is earlier than the JGroups JAR then our config > will be found first and used. > > This change also allows us to simplify the configuration code in LogService. > > The log4j2-cli.xml also moves to the root of the gemfire-core JAR which means > the gfsh scripts can directly reference it by prefixing "classpath:" on the > value of the configuration system property. > > Overall these changes are much better for the product and I'd recommend > making these changes even if JGroups wasn't changing. > > Tests are altered, deleted and updated as needed. System-rules JUnit rules > are updated to version 1.12.1. > > I intend to commit these changes to develop and then we can down-merge this > to the GEODE-77 feature branch. > > > Diffs > ----- > > build.gradle c1534de > gemfire-assembly/build.gradle f65930d > gemfire-assembly/src/main/dist/bin/gfsh e700aae > gemfire-assembly/src/main/dist/bin/gfsh.bat c4a9480 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/LogService.java > 637f8ca > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/logging/log4j/Configurator.java > e07f214 > > gemfire-core/src/main/resources/com/gemstone/gemfire/internal/logging/log4j/log4j2-cli.xml > 14b7075 > > gemfire-core/src/main/resources/com/gemstone/gemfire/internal/logging/log4j/log4j2-default.xml > a6e8cd8 > gemfire-core/src/main/resources/log4j2-cli.xml PRE-CREATION > gemfire-core/src/main/resources/log4j2.xml PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceIntegrationJUnitTest.java > 6425c1f > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceJUnitTest.java > 8d6278a > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LogServiceUserDirIntegrationJUnitTest.java > 4d83c22 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingIntegrationTestSuite.java > dd9504b > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/LoggingUnitTestSuite.java > 6b7b73e > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/MergeLogFilesJUnitTest.java > d8d774c > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerIntegrationJUnitTest.java > f1c7ab9 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/logging/log4j/FastLoggerWithDefaultConfigJUnitTest.java > 2e08500 > > Diff: https://reviews.apache.org/r/39290/diff/ > > > Testing > ------- > > precheckin-all > > > Thanks, > > Kirk Lund > >
