----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39326/ -----------------------------------------------------------
Review request for geode, anilkumar gingade, Hitesh Khamesra, Jason Huynh, Jianxia Chen, and Lynn Gallinat. Repository: geode Description ------- Geode expects a JVM to exit if the server Acceptor thread dies in a JVM launched by Gfsh. The old SystemAdmin class also expects this to happen, triggering the shutdown-hook in InternalDistributedSystem. JGroups creates a number of executors that could be configured to create daemon threads but the TP transport protocol currently has no way of configuring this. I've asked if there is a way to daemon-ize the JGroups threads but in the meantime I've introduced a subclass of the transport protocol (UDP) that forces the thread factories to create daemon threads. I've also added code to setTimeToLive that avoids trying to set the TTL if we're not going to use multicast. This was causing ERROR level log messages on a dual-stack Windows-7 implementation. Diffs ----- gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/AddressManager.java a1305d54da1607d65ac03b8991daca37a9f45232 gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java 556f974278c8ab260246331fab672c25e87e4fe3 gemfire-core/src/main/java/com/gemstone/gemfire/internal/SystemAdmin.java 6c4b01cf5d14d33b11b356cb269cb80cd68a9b45 gemfire-core/src/main/resources/com/gemstone/gemfire/distributed/internal/jgroups-config.xml 73e66b43bf782fb7fc449757951cbd72cd85aa8e gemfire-core/src/main/resources/com/gemstone/gemfire/distributed/internal/jgroups-mcast.xml 4c6f25c5177c5aed1784402e177ae3da273bc9b2 gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessengerJUnitTest.java 985cfb54166da7f1bcaccc301e172c3d5c5e8395 Diff: https://reviews.apache.org/r/39326/diff/ Testing ------- unit tests (running now) integration testing Thanks, Bruce Schuchardt
