> On Oct. 14, 2015, 9:32 p.m., Darrel Schneider wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java, > > line 3735 > > <https://reviews.apache.org/r/39328/diff/1/?file=1098538#file1098538line3735> > > > > Would it be better for the collection to be synchronized instead of > > using a possibly wider cache sync?
I'll change it. > On Oct. 14, 2015, 9:32 p.m., Darrel Schneider wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionListener.java, > > line 7 > > <https://reviews.apache.org/r/39328/diff/1/?file=1098540#file1098540line7> > > > > "on a ??? that" Fixed that! - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39328/#review102706 ----------------------------------------------------------- On Oct. 15, 2015, 5:18 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39328/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2015, 5:18 p.m.) > > > Review request for geode, Ashvin A, Darrel Schneider, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > This listener is attached to the cache and gets a callback before any > region is created. This can be used by extensions to modify region > attributes to create resources need for a region before the region is > created. > > This listener is needed to allow lucene to add an async event queue to the > region attributes at region creation time. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java > b0f0f43be2d2beaac66256d5b07b0fd8c35ffe9c > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > 9e5bcd286f802d03bc558a03a33e5cfb100b4683 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionListener.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RegionListenerJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/39328/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
