----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39361/ -----------------------------------------------------------
Review request for geode, Ashvin A, Jacob Barrett, and xiaojian zhou. Repository: geode Description ------- I had previously modified the existing Extension mechanism on this branch to be able to fetch Extensions by key. However, after digging more, I think those Extensions are mostly just useful for Xml parsing since they have callbacks specific to transitioning an object from a *Creation to a real object. In addition, I was worried the changes I made would break existing extensions. So I have rolled back those changes. Instead of that, I've added the concept of a CacheService, which is loaded by the ServiceLoader during cache initialization and has the same lifecycle as the cache. Services can be retrieved using GemfireCacheImpl.getService(SomeService.class). I've used this new mechanism to install the LuceneService. This is currently only an internal service, but we may want to make this public, eg Cache.getService(SomeService.class) Diffs ----- gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheService.java PRE-CREATION gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java e73af4929f38b5c0084d01e099b0150244a1e06f gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/InternalCache.java cf1a4dc1a79832077dfe5de237a6a3e457984b46 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/extension/ExtensionPoint.java dedc50f1c53a15e5681f443739f01e57ae10c5fb gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/extension/SimpleExtensionPoint.java 06e855fc8696a9ac19bd6c993732bc59c082a91e gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheCreation.java 31de4e9612771c1c517c01b2118f650e3e89f63a gemfire-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml81DUnitTest.java 54f1208b93e62dc9c2641bdd0237459888be4846 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/CacheServiceJUnitTest.java PRE-CREATION gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/MockCacheService.java PRE-CREATION gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/MockCacheServiceImpl.java PRE-CREATION gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/extension/SimpleExtensionPointJUnitTest.java 35bb7ef1638719c5516af2280192f911db7ce1f4 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/extension/mock/DestroyMockCacheExtensionFunction.java 29b6acb55b79a1c0c1954b99e02d50e0c05cd667 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/extension/mock/MockCacheExtension.java b5b9e6504fd787da735444271dbad007f5668e31 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/extension/mock/MockExtensionXmlParser.java cf9a2ecd84b7d06048b4a5568c15d0ef4f02c1fb gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/extension/mock/MockRegionExtension.java 571b5a111971eae2ce8a8ffe4d56a76d30181750 gemfire-core/src/test/resources/META-INF/services/com.gemstone.gemfire.internal.cache.CacheService PRE-CREATION gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/LuceneServiceProvider.java 7d90b7d6369b9441309c7dd29cc04bd63f412dfc gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/InternalLuceneService.java d09ef19538ef6245dcd6536c45c10a2d8c303deb gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImpl.java 257861b5f3b4e25c30a2bc05835562eddde33fcd gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java c4a2047ec6676ab303cef1eac0fa12675542e6b3 gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexCreation.java 02ecd8fdd8e336fc447cdd8cf41b4c651039545f gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneXmlParser.java e11814a107301b153c4bfab472c375156226a0e9 gemfire-lucene/src/main/resources/META-INF/services/com.gemstone.gemfire.internal.cache.CacheService PRE-CREATION gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java 26487a0e34cc5ad130428c8af88644e3d80a3425 gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java 6c37468a91e0097c38987b8f4b41a3b0f27d7852 Diff: https://reviews.apache.org/r/39361/diff/ Testing ------- Thanks, Dan Smith
