> On Oct. 22, 2015, 6:55 p.m., John Blum wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java, > > line 255 > > <https://reviews.apache.org/r/39023/diff/1/?file=1091310#file1091310line255> > > > > Make the "scheme" parameter final for consistency. > > > > Typically, you should add parameters to the end of the method parameter > > list and also include a method such as... > > > > protected static final String DEFAULT_SCHEME = "http"; > > > > ... > > > > protected URI toUri(final String path) { > > return toUri(path, DEFAULT_SCHEME); > > } > > > > This will help minimize the necessary code changes in areas of the code > > that are not affected by the scheme.
I made the suggested changes other than providing a method with the same existing signature as currently exists. It's not a public method and there is currently only one other method which calls toUri() so it seems a little superfluous. - Jens ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39023/#review103635 ----------------------------------------------------------- On Oct. 5, 2015, 10:10 p.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39023/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 10:10 p.m.) > > > Review request for geode and John Blum. > > > Repository: geode > > > Description > ------- > > GEODE-381 enable gfsh https usage through SSL terminated environments > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/ShellCommands.java > 4bdab90ef905731c19568b0d7638ebb5bbe577bb > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/AbstractCommandsController.java > 73ce9265eb0f4d260b18919d3478738656fec073 > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/web/controllers/ShellCommandsController.java > ef4c49f1a5434cfae1e7fac2db3577cef7a0c834 > gemfire-web/build.gradle b9629d30a66d70e9283987ab2db8d4bb2b2f08a1 > > gemfire-web/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/ShellCommandsControllerJUnitTest.java > 34aa28589cf1c30dbf37abe1c17f92749dea835a > > Diff: https://reviews.apache.org/r/39023/diff/ > > > Testing > ------- > > Ran Management JUnit tests > > > Thanks, > > Jens Deppe > >
